public inbox for nncp-devel@lists.cypherpunks.ru
Atom feed
* Errors building NNCP with Go 1.22
@ 2024-07-23  4:51 John Goerzen
  2024-07-23  6:36 ` Alexis
  2024-07-23 10:38 ` Errors building NNCP with Go 1.22 Sergey Matveev
  0 siblings, 2 replies; 7+ messages in thread
From: John Goerzen @ 2024-07-23  4:51 UTC (permalink / raw)
  To: nncp-devel

Hi Sergey,

I received an email earlier this week about problems building NNCP with
Golang 1.22:

vendor/gvisor.dev/gvisor/pkg/sync/gate_unsafe.go:114:3: undefined: goready
vendor/gvisor.dev/gvisor/pkg/sync/gate_unsafe.go:144:2: undefined: gopark
vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:76:3: undefined: semacquire
vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:102:4: undefined: semrelease
vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:152:3: undefined: semacquire
vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:179:3: undefined: semrelease
vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:207:3: undefined: semrelease
vendor/gvisor.dev/gvisor/pkg/sync/seqcount.go:87:6: undefined: canSpin
vendor/gvisor.dev/gvisor/pkg/sync/seqcount.go:89:4: undefined: doSpin

I can confirm that myself.  Maybe the fix would be as easy as updating
the dependencies?

By the way, still going strong with NNCP over here.  The quux.org public
node is slowly adding new peers also.  Thanks for what you do for NNCP!

- John

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Errors building NNCP with Go 1.22
  2024-07-23  4:51 Errors building NNCP with Go 1.22 John Goerzen
@ 2024-07-23  6:36 ` Alexis
  2024-07-23 10:44   ` Sergey Matveev
  2024-07-23 10:38 ` Errors building NNCP with Go 1.22 Sergey Matveev
  1 sibling, 1 reply; 7+ messages in thread
From: Alexis @ 2024-07-23  6:36 UTC (permalink / raw)
  To: nncp-devel; +Cc: John Goerzen

John Goerzen <jgoerzen@complete•org> writes:

> Hi Sergey,
>
> I received an email earlier this week about problems building 
> NNCP with
> Golang 1.22:
>
> vendor/gvisor.dev/gvisor/pkg/sync/gate_unsafe.go:114:3: 
> undefined: goready
> vendor/gvisor.dev/gvisor/pkg/sync/gate_unsafe.go:144:2: 
> undefined: gopark
> vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:76:3: 
> undefined: semacquire
> vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:102:4: 
> undefined: semrelease
> vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:152:3: 
> undefined: semacquire
> vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:179:3: 
> undefined: semrelease
> vendor/gvisor.dev/gvisor/pkg/sync/rwmutex_unsafe.go:207:3: 
> undefined: semrelease
> vendor/gvisor.dev/gvisor/pkg/sync/seqcount.go:87:6: undefined: 
> canSpin
> vendor/gvisor.dev/gvisor/pkg/sync/seqcount.go:89:4: undefined: 
> doSpin
>
> I can confirm that myself.  Maybe the fix would be as easy as 
> updating
> the dependencies?
>
> By the way, still going strong with NNCP over here.  The 
> quux.org public
> node is slowly adding new peers also.  Thanks for what you do 
> for NNCP!
>
> - John

Thanks John, you beat me to it!

i was the person who sent the initial email to John (as i'd 
incorrectly assumed he was the primary maintainer).

In addition to the above:

* i get this error regardless of whether i build and use the 
  Gentoo package (which only has one patch to upstream, 
  `go-never-download-newer-toolchains.patch`), or download and use 
  the version provided at go.dev.

* Although 
  https://nncp.mirrors.quux.org/Build_002dinstructions.html notes 
  that:

> currently building with Go 1.22 is impossible unless noyggdrasil 
> tag is set

(which doesn't seem to be noted in the INSTALL file in the 8.10.0 
tarball), trying to build via:

    GO_CFLAGS="-tags noyggdrasil" bin/build

fails with the error:

    # go.cypherpunks.ru/nncp/v8/yggdrasil
    yggdrasil/yggdrasil_dummy.go:30:53: undefined: ConnDeadlined


Alexis.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Errors building NNCP with Go 1.22
  2024-07-23  4:51 Errors building NNCP with Go 1.22 John Goerzen
  2024-07-23  6:36 ` Alexis
@ 2024-07-23 10:38 ` Sergey Matveev
  1 sibling, 0 replies; 7+ messages in thread
From: Sergey Matveev @ 2024-07-23 10:38 UTC (permalink / raw)
  To: nncp-devel

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Greetings!

*** John Goerzen [2024-07-22 23:51]:
>I received an email earlier this week about problems building NNCP with
>Golang 1.22: [...]

Thanks for the feedback! Have not rebuild NNCP for a long time, although
used Go 1.22 since its release.

>I can confirm that myself.  Maybe the fix would be as easy as updating
>the dependencies?

Because of constant gvisor's API changes it is not so trivial, but I
done that in 8.11.0 release.

>By the way, still going strong with NNCP over here.  The quux.org public
>node is slowly adding new peers also.  Thanks for what you do for NNCP!

Cool! Glad to hear that!

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967  FD75 CB82 0563 2107 AD8A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Errors building NNCP with Go 1.22
  2024-07-23  6:36 ` Alexis
@ 2024-07-23 10:44   ` Sergey Matveev
  2024-08-13  4:37     ` Alexis
  0 siblings, 1 reply; 7+ messages in thread
From: Sergey Matveev @ 2024-07-23 10:44 UTC (permalink / raw)
  To: nncp-devel

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

Greetings!

*** Alexis [2024-07-23 16:36]:
>> currently building with Go 1.22 is impossible unless noyggdrasil tag is
>(which doesn't seem to be noted in the INSTALL file in the 8.10.0 tarball),
>trying to build via:
>GO_CFLAGS="-tags noyggdrasil" bin/build
>fails with the error: [...]

Yeah, 8.10.0 tarball contains invalid code, that won't build at all with
"-tags noyggdrasil". Seems that after some refactoring I forgot even an
attempt to build it without Yggdrasil support. Remark on the website was
added after the release. It is fixed in 8.11.0 release now.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: 12AD 3268 9C66 0D42 6967  FD75 CB82 0563 2107 AD8A

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Errors building NNCP with Go 1.22
  2024-07-23 10:44   ` Sergey Matveev
@ 2024-08-13  4:37     ` Alexis
  2024-08-14 16:13       ` NNCP Gentoo ebuild testing Jonathan Lane
  0 siblings, 1 reply; 7+ messages in thread
From: Alexis @ 2024-08-13  4:37 UTC (permalink / raw)
  To: nncp-devel

Sergey Matveev <stargrave@stargrave•org> writes:

> Yeah, 8.10.0 tarball contains invalid code, that won't build at 
> all
> with
> "-tags noyggdrasil". Seems that after some refactoring I forgot 
> even an
> attempt to build it without Yggdrasil support. Remark on the 
> website
> was
> added after the release. It is fixed in 8.11.0 release now.

Sorry to have taken so long to respond; i always have lots of 
plates spinning ....

Thanks for this! It now builds successfully. :-)

i've just added a Gentoo ebuild for it to my 'flexibeast' overlay:

  https://git.sr.ht/~flexibeast/gentoo-overlay

significantly based on zscheile's ebuild:

  https://gpo.zugaina.org/Overlays/zscheile/net-misc/nncp

The new ebuild doesn't currently appear on gpo.zugaina.org:

  https://gpo.zugaina.org/Overlays/flexibeast

but it's certainly available by enabling and syncing the 
'flexibeast' overlay:

  # eselect repository enable flexibeast
  # emaint sync -r flexibeast

As i noted in an earlier message, i'm new to the Go build 
environment, so please let me know of any issues (or general 
feedback).


Alexis.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* NNCP Gentoo ebuild testing
  2024-08-13  4:37     ` Alexis
@ 2024-08-14 16:13       ` Jonathan Lane
  2024-08-15  0:18         ` Alexis
  0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Lane @ 2024-08-14 16:13 UTC (permalink / raw)
  To: nncp-devel

It built successfully on my ~amd64 OpenRC system.  My one bit of
feedback is that you should probably make the compilation step more
verbose to help diagnose build failures, as a precaution.

On Tue, Aug 13, 2024 at 02:37:55PM +1000, Alexis wrote:
> i've just added a Gentoo ebuild for it to my 'flexibeast' overlay:
> 
>  https://git.sr.ht/~flexibeast/gentoo-overlay
> 
> significantly based on zscheile's ebuild:
> 
>  https://gpo.zugaina.org/Overlays/zscheile/net-misc/nncp
> 
> The new ebuild doesn't currently appear on gpo.zugaina.org:
> 
>  https://gpo.zugaina.org/Overlays/flexibeast
> 
> but it's certainly available by enabling and syncing the 'flexibeast'
> overlay:
> 
>  # eselect repository enable flexibeast
>  # emaint sync -r flexibeast
> 
> As i noted in an earlier message, i'm new to the Go build environment, so
> please let me know of any issues (or general feedback).
> 
> 
> Alexis.
> 

-- 
tidux@sdf•org
SDF Public Access UNIX System - http://sdf.org

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: NNCP Gentoo ebuild testing
  2024-08-14 16:13       ` NNCP Gentoo ebuild testing Jonathan Lane
@ 2024-08-15  0:18         ` Alexis
  0 siblings, 0 replies; 7+ messages in thread
From: Alexis @ 2024-08-15  0:18 UTC (permalink / raw)
  To: Jonathan Lane; +Cc: nncp-devel

Jonathan Lane <tidux@sdf•org> writes:

> It built successfully on my ~amd64 OpenRC system.  My one bit of
> feedback is that you should probably make the compilation step 
> more
> verbose to help diagnose build failures, as a precaution.

Thanks for the feedback. :-) Good point! i've now added an `-r2` 
ebuild that uses `-v -work -x`, as done by the 
`golang-build_src_compile` function from the `golang-build` 
eclass.


Alexis.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-08-15  0:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-23  4:51 Errors building NNCP with Go 1.22 John Goerzen
2024-07-23  6:36 ` Alexis
2024-07-23 10:44   ` Sergey Matveev
2024-08-13  4:37     ` Alexis
2024-08-14 16:13       ` NNCP Gentoo ebuild testing Jonathan Lane
2024-08-15  0:18         ` Alexis
2024-07-23 10:38 ` Errors building NNCP with Go 1.22 Sergey Matveev