public inbox for nncp-devel@lists.cypherpunks.ru
Atom feed
From: Sergey Matveev <stargrave@stargrave•org>
To: nncp-devel@lists.cypherpunks.ru
Subject: Re: [EN] NNCP 5.5.0 release announcement
Date: Fri, 8 Jan 2021 12:45:16 +0300	[thread overview]
Message-ID: <X/gpujr/6EmP3Qq0@stargrave.org> (raw)
In-Reply-To: <87lfd4787f.fsf@complete.org>

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Greetings!

*** John Goerzen [2021-01-07 15:23]:
>	previous declaration at 	golang.org/x/term/term_unix_aix.go:9:26

It looks like your Go thinks he is both AIX and Linux. I have copied
golang.org/x/term without any modifications from the upstream. I assume
that you probably have old Go version what does not know anything about
AIX and does not treat "_aix" as a build-tag. As I can see, firstly it
appeared https://github.com/golang/go/commit/bf8e6b70276ddfd3e070964542020fe782c1eec8
at 2018 year.

Currently (in develop branch) NNCP uses golang.org/x/term instead of
golang.org/x/crypto/ssh/terminal, that anyway depends on golang.org/x/term.
So that "term" dependency anyway is there and upstream has knowledge
about AIX. I suggest you to update your Go, that will also bring
performance benefits as a rule. Or just: find . -name \*_aix.go -delete

I have tried Go 1.10 -- the same problem as you have.
I have tried Go 1.11 -- same problem.
I have tried Go 1.12 -- build/test is ok.

So I will update documentation and raise Go's 1.10+ version to 1.12.

I have found some Ubuntu virtual machine image and tested building on
it with the golang-go taken from repository (go1.13.8) -- builds fine.

-- 
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263  6422 AE1A 8109 E498 57EF

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-01-08  9:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 15:31 [EN] NNCP 5.5.0 release announcement Sergey Matveev
2021-01-07 21:23 ` John Goerzen
2021-01-07 21:32   ` New -autotoss option John Goerzen
2021-01-08 10:00     ` Sergey Matveev
2021-01-08 10:01       ` Sergey Matveev
2021-01-08 13:38         ` John Goerzen
2021-01-08  9:45   ` Sergey Matveev [this message]
2021-01-08 13:43     ` [EN] NNCP 5.5.0 release announcement John Goerzen
2021-01-08 13:53       ` Sergey Matveev