public inbox for goredo-devel@lists.cypherpunks.su
Atom feed
* Paths in .rec files still buggy
@ 2021-09-15 10:50 goredo
2021-09-15 20:24 ` Sergey Matveev
0 siblings, 1 reply; 3+ messages in thread
From: goredo @ 2021-09-15 10:50 UTC (permalink / raw)
To: goredo-devel
I just discovered a bug in recorded entries in .rec files. Conditions:
- do file is in /a/b/default.do
- target is in a sub-directory: /a/b/c/file
- it creates an if-create dependency to a file outside the current sub tree: /a/c/dep
- it also(!) has an ifchange dependency on /a/b/c/dep
- the if-create dependency is generated with `redo-ifcreate ../c/dep` (due to the do file being in /a)
- the if-create dependency is recorded in /a/b/c/.redo/file.rec as `../c/dep` as well
- during ood scanning, this resolves to /a/b/c/dep, although it should resolve to /a/c/dep, with the consequence that it is detected as 'created', which ood's the target /a/b/c/file every time. So, it seems that during ood scanning the paths are not resolved in relation to the do file but in relation to the target file.
Kind regards,
–Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Paths in .rec files still buggy
2021-09-15 10:50 Paths in .rec files still buggy goredo
@ 2021-09-15 20:24 ` Sergey Matveev
2021-09-16 7:31 ` goredo
0 siblings, 1 reply; 3+ messages in thread
From: Sergey Matveev @ 2021-09-15 20:24 UTC (permalink / raw)
To: goredo-devel
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
Greetings!
Thanks for reporting this! I made test for that issue exactly as you
described it: http://www.git.cypherpunks.ru/?p=goredo.git;a=blob;f=t/goredo-rel-ifcreate.t
and fixed in 1.14.0 release.
--
Sergey Matveev (http://www.stargrave.org/)
OpenPGP: CF60 E89A 5923 1E76 E263 6422 AE1A 8109 E498 57EF
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Paths in .rec files still buggy
2021-09-15 20:24 ` Sergey Matveev
@ 2021-09-16 7:31 ` goredo
0 siblings, 0 replies; 3+ messages in thread
From: goredo @ 2021-09-16 7:31 UTC (permalink / raw)
To: goredo-devel
Thanks, everything works now.
–Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-16 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 10:50 Paths in .rec files still buggy goredo
2021-09-15 20:24 ` Sergey Matveev
2021-09-16 7:31 ` goredo